Skip to content

Conversation

@yurug
Copy link
Collaborator

@yurug yurug commented Jan 6, 2020

Should fix #337.

@yurug yurug merged commit 8820ae4 into master Jan 6, 2020
@erikmd
Copy link
Collaborator

erikmd commented Jan 8, 2020

Dear @yurug, I've noticed that when students click on Sync, as there is no popup or so saying "Sync succeeded", some want to click once again "just to be on the safe side", so that with the latest version, there will be much more (empty) commits.

Do you think this is an issue?

If yes, one can just as well keep the change of #338 as is, and implement a notification popup in another PR? (e.g. with this MIT-licensed plugin: http://bootstrap-notify.remabledesigns.com, or maybe a simpler implementation with a manual timeout)
Should I create a separate issue for this idea?

@erikmd erikmd deleted the allow-empty-commit branch December 21, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fail to view student contributions

3 participants