-
Notifications
You must be signed in to change notification settings - Fork 71
Labels
kind: enhancementEnhancement to an existing user-facing feature.Enhancement to an existing user-facing feature.
Milestone
Description
Related user(s):
Related issue(s) or PR(s):
Related project scope(s):
build
The problem:
-
As a follow-up of Task: auto-deploy Docker images of master and tags for arm64 arch as well #611,
ocamlsf/learn-ocaml:masternow supports thearm64arch: -
FYI I've just tested this succesfully on a MacBook Air (Apple M1), where the platform warning does not show up anymore after pulling the
masterimage:
% docker run --rm -v "$PWD/demo-repository:/repository" -p 8080:8080 ocamlsf/learn-ocaml:1.0.0 # old release
WARNING: The requested image\'s platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
Learnocaml v.1.0.0 running.
Updating app at ./www
Learnocaml server v.1.0.0 starting on port 8080
Initial teacher token created: X-DJU-OCG-JA9-4SS
^CSIGINT caught: stopping
% docker pull ocamlsf/learn-ocaml:master
% docker run --rm -v "$PWD/demo-repository:/repository" -p 8080:8080 ocamlsf/learn-ocaml:master
Learnocaml v1.1.0 running.
Updating app at ./www
Learnocaml server v1.1.0 starting on port 8080
Initial teacher token created: X-USS-1NS-ZSJ-URO
^CSIGINT caught: stopping- However, this change only deals with the workflow
deploy-master.yml
Wanted solution:
- To Do: also apply this change to
release.yml(the workflow file for tags)
Considered alternatives:
N/A
Additional context:
No response
Metadata
Metadata
Assignees
Labels
kind: enhancementEnhancement to an existing user-facing feature.Enhancement to an existing user-facing feature.
