Skip to content

coerce to date for temporal thresholds #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2021
Merged

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Oct 1, 2021

If a time interval or an array of dates is specified as the thresholds option to the bin transform, the bin transform now implicitly coerces the values to the dates in the same fashion as a temporal scale.

@mbostock mbostock requested a review from Fil October 1, 2021 17:02
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. In README I wonder if the definition of "interval" could be a little more explicit.

@mbostock mbostock merged commit 14ded29 into main Oct 1, 2021
@mbostock mbostock deleted the mbostock/bin-date-coercion branch October 1, 2021 19:11
@mbostock mbostock mentioned this pull request Mar 14, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants