Add shape-rendering to mark style #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks! Have you by any chance looked at the examples in the test/plots/ directory and seen a plot that would benefit from using the option? |
Contributor
Author
|
I didn't see any test plot that could benefit so I added a new snapshot test (which could be a useful example when #415 lands too). There's also two new small unit tests. |
Contributor
|
I've added a build in https://observablehq.com/@fil/quantile-threshold-shaperendering-415-419 |
mbostock
requested changes
Jul 20, 2021
src/style.js
Outdated
| mark.strokeMiterlimit = impliedNumber(strokeMiterlimit, 4); | ||
| mark.strokeDasharray = string(strokeDasharray); | ||
| mark.mixBlendMode = impliedString(mixBlendMode, "normal"); | ||
| mark.shapeRendering = string(shapeRendering); |
Member
There was a problem hiding this comment.
Suggested change
| mark.shapeRendering = string(shapeRendering); | |
| mark.shapeRendering = impliedString(shapeRendering, "auto"); |
mbostock
reviewed
Aug 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the shape-rendering attribute to the list of mark styles.