Skip to content

explicit error message when the required channel is missing in selectMaxX #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2021
Merged

explicit error message when the required channel is missing in selectMaxX #404

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5139e71
explicit error message when the required channel is missing in select…
Fil May 14, 2021
240d0ba
throw new Error
Fil May 15, 2021
4cd8b55
null, not undefined
mbostock Aug 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/transforms/select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,27 @@ export function selectLast(options) {
}

export function selectMinX(options = {}) {
return select(min, options.x, options);
const x = options.x;
if (x == null) throw new Error("missing channel: x");
return select(min, x, options);
}

export function selectMinY(options = {}) {
return select(min, options.y, options);
const y = options.y;
if (y == null) throw new Error("missing channel: y");
return select(min, y, options);
}

export function selectMaxX(options = {}) {
return select(max, options.x, options);
const x = options.x;
if (x == null) throw new Error("missing channel: x");
return select(max, x, options);
}

export function selectMaxY(options = {}) {
return select(max, options.y, options);
const y = options.y;
if (y == null) throw new Error("missing channel: y");
return select(max, y, options);
}

// TODO If the value (for some required channel) is undefined, scan forward?
Expand Down