Skip to content

allow jsdoc type declarations #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2022
Merged

allow jsdoc type declarations #1110

merged 2 commits into from
Nov 23, 2022

Conversation

mbostock
Copy link
Member

I didn’t test thoroughly, but it seems to work for the simple cases like so:

/** @jsdoc plot */
/**
 * @jsdoc plot
 */
/**
 * @jsdoc plot
 * @param {Options=} options
 */

Ref. #1096 (comment)

@mbostock mbostock requested a review from duaneatat November 23, 2022 15:23
duaneatat
duaneatat approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@duaneatat duaneatat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 tested it out as well, works nicely!

@mbostock mbostock merged commit 21dc1c7 into main Nov 23, 2022
@mbostock mbostock deleted the mbostock/allow-jsdoc-type-declarations branch November 23, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@duaneatat duaneatat duaneatat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mbostock @duaneatat