Skip to content

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Jul 29, 2022

Enregistrement.de.l.ecran.2022-07-29.a.10.23.48.mov

@Fil Fil mentioned this pull request Jul 29, 2022
12 tasks
@Fil Fil mentioned this pull request Aug 1, 2022
@Fil
Copy link
Contributor Author

Fil commented Aug 1, 2022

Almost working now, but there's a bit of an object constancy problem with transforms:

  • sorting creates mix-ups across keyframes; temporary fix by sorting each facet by index—it's not the right call
  • the outliers part of the dotX mark, because it doesn't have the same cardinality from one keyframe to the other; I'm not sure how to attack this theoretically; maybe some reconciliation algorithm? EDIT: another possibility to explore would be to have a mark opt out of linear interpolation and ask for fade out/fade in instead.

@Fil
Copy link
Contributor Author

Fil commented Aug 2, 2022

to test 61a60cf you can just paste this in the gapminder.js example:
Plot.link([[200, 30, 1957], [100000, 100, 2007]], {x1: 200, y1:30, x2: "0", y2:"1", time: "2"}),
and watch that link “grow”

Enregistrement.de.l.ecran.2022-08-02.a.12.13.02.mov

@Fil
Copy link
Contributor Author

Fil commented Aug 3, 2022

Fixed the box plot by adding an animate="fade" option (defaults to "interpolate")

Enregistrement.de.l.ecran.2022-08-03.a.10.48.37.mov

* enter, update, exit
* bar chart race
@Fil
Copy link
Contributor Author

Fil commented Aug 3, 2022

@Fil
Copy link
Contributor Author

Fil commented Aug 4, 2022

A half-related suggestion would allow these updates to be nicer on the DOM #1022

Not part of this PR, because it's a bit orthogonal (although we don't need it unless we want to animate a mark).

@mbostock
Copy link
Member

mbostock commented Aug 8, 2022

Fil, you might want to start developing additional functionality (e.g., timing parameters and programmatic control) in a separate PR so that we can focus on reviewing the core code here. Keeping the core PR smaller could make it easier to review. But we’ll chat today and see how it goes.

@Fil Fil marked this pull request as ready for review August 10, 2022 09:52
@Fil
Copy link
Contributor Author

Fil commented Aug 10, 2022

CI doesn't work since this is not targeting main; we'll see later.

@Fil Fil marked this pull request as draft August 10, 2022 09:56
@Fil Fil mentioned this pull request Sep 5, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants