-
Notifications
You must be signed in to change notification settings - Fork 29
acorn 8, esm, mocha #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
acorn 8, esm, mocha #205
Conversation
633e7dc to
f2a0461
Compare
|
If you want to compare to the pre-Tap snapshots of yore: |
|
sorry I've been slow to get to this! one thing I just wanted to call out is that we do use |
|
Okay, I’ll restore the peekId functionality. |
|
Okay @sydneypalumbo this should be ready for another look! Thanks. |
sydneypalumbo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This:
We could do this change more minimally, but I think we’re going to want to do this in the near future anyway, so we might as well tie breaking changes together to minimize the number of major version bumps.