Skip to content

Conversation

@mbostock
Copy link
Member

@mbostock mbostock commented Nov 14, 2021

This:

  • Upgrades to Acorn 8, fixing Class fields support #64.
  • Upgrades yarn.lock.
  • Changes the default ecmaVersion from 12 to 13.
  • Adopts ES modules, replacing standard-things/esm.
  • Adopts Mocha, replacing Tap.
  • Adopts ESLint in GitHub actions.
  • Requires Node 14+.
  • Drops experimental parseModule functionality.

We could do this change more minimally, but I think we’re going to want to do this in the near future anyway, so we might as well tie breaking changes together to minimize the number of major version bumps.

@mbostock mbostock mentioned this pull request Nov 14, 2021
@mbostock mbostock force-pushed the mbostock/update-acorn branch from 633e7dc to f2a0461 Compare November 14, 2021 17:32
@mbostock
Copy link
Member Author

If you want to compare to the pre-Tap snapshots of yore:

812e84e~...mbostock/update-acorn

@sydneypalumbo
Copy link
Contributor

sorry I've been slow to get to this! one thing I just wanted to call out is that we do use peekId when constructing document history currently in order to get cell names (we could either remove that logic now or do a normal parse if we wanted to keep it)

@mbostock
Copy link
Member Author

Okay, I’ll restore the peekId functionality.

@mbostock
Copy link
Member Author

Okay @sydneypalumbo this should be ready for another look! Thanks.

Copy link
Contributor

@sydneypalumbo sydneypalumbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mbostock mbostock merged commit 23025bc into main Dec 24, 2021
@mbostock mbostock deleted the mbostock/update-acorn branch December 24, 2021 00:38
@mbostock mbostock mentioned this pull request Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants