Bdeboe refinements #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an origin entity contains a single-character word, require it to be at the start of a word in the destination entity, rather than anywhere. i.e. "hepatitis b vaccine" previously would be a child to "hepatitis c" because of the c in vaccine, but now no longer is. Note that there's many other refinements that may work well for some environments but cause collateral damage elsewhere. This this felt generic enough to be useful in weeding out some false positives, but not too blunt in causing false negatives.
Apparently we need to set the CHARSET parameter on the routing class (EntityBrowser.Router) as the one in the class routed to (EntityBrowser.API) is ignored.
This was referenced May 29, 2018
Merged
Enforce utf-8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's merge it into master