Skip to content

Conversation

@jhermsmeier
Copy link

Fixes #557

@jcdogo
Copy link

jcdogo commented Oct 9, 2020

This is a bad fix and should be closed. It actually breaks the server. code.authorizationCode is used in 5 different files, whereas this only changes it in one file. In addition, even if you changed all 5 files, it would become a breaking change for all existing users of this library.

Rather than changing the code, the model spec just needs to be correct to reflect what the code is actually doing.

@jhermsmeier
Copy link
Author

Thanks for that valuable, and friendly comment. I'm just going to leave it to you to do the good fixes then :)

@jhermsmeier jhermsmeier closed this Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

saveToken passes wrong parameter

2 participants