Pass correct "this" to the model. #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this change and it works for me as well. This change allows me to pass in class objects for the model and retain proper "this" context. |
|
@mjsalinger What do you think about this change? |
|
This is feature I would love to see. For anyone who wants to use a class for the model right now: Currently a simple (but annoying) fix is to bind the model functions to the model context in the class constructor: this.generateAuthorizationCode = this.generateAuthorizationCode.bind(this); |
Contributor
|
@danbell Can you rebase? I'll merge it if you do. |
danbell
force-pushed
the
feature/model-is-passed-this
branch
from
01e9a2b to
5f48a5c
Compare
Contributor
Author
|
@mjsalinger - done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows "this" to be used within the model. This completes and obsoletes #320.