Skip to content

Conversation

@hasecilu
Copy link
Collaborator

@hasecilu hasecilu commented Apr 9, 2024

Fix #440

@parkerkain-8451

This comment was marked as off-topic.

@hasecilu hasecilu force-pushed the fix/dash_causing_error branch from 8a0d266 to 1121605 Compare April 9, 2024 14:37
@gegoune
Copy link
Collaborator

gegoune commented Apr 9, 2024

I don't have any problem with neither - nor _. I am on 0.10, so perhaps it's different on 0.9? Could someone on stable confirm if those work:

:hi foo-bar gui=bold
:hi foo_bar gui=bold

(Both work on 0.10.)

While / errors.

@hasecilu
Copy link
Collaborator Author

hasecilu commented Apr 9, 2024

I don't have any problem with neither - nor _. I am on 0.10, so perhaps it's different on 0.9? Could someone on stable confirm if those work:

:hi foo-bar gui=bold
:hi foo_bar gui=bold

(Both work on 0.10.)

While / errors.

Same here but with NVIM v0.9.5, LuaJIT 2.1.1702233742.
For me dash and underscore work and slash fails.

@haakonfp
Copy link

haakonfp commented Apr 9, 2024

on v0.9.4. I have the issues mentioned in #440.

:hi foo-bar gui=bold errors.
:hi foo_bar gui=bold does not error.
:hi foo/bar gui=bold also errors.

@meatballs
Copy link

Turns out I was still on 0.9.1 Updating to 0.9.5 solved the problems in #440

@hasecilu hasecilu mentioned this pull request Apr 9, 2024
@gegoune
Copy link
Collaborator

gegoune commented Apr 9, 2024

Thanks for the fix @hasecilu.
Let's merge it in, group names look better that way anyway and it fixes backwards incompatibility.

@gegoune gegoune merged commit 6e35563 into nvim-tree:master Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid highlight name

5 participants