Skip to content

Conversation

@ofseed
Copy link
Contributor

@ofseed ofseed commented Jan 12, 2024

Do not merge both this and #376

808627b 'fix: update js icon (nvim-tree#366)'
33e27b8 'fix: update cjs & mjs icons (nvim-tree#368)'
@alex-courtis
Copy link
Member

Many thanks @ofseed and all for the great discussion.

I've updated #192 to move to css class names.
#391 will then consolidate on seti icons
#392 will add a material set

I'll close this and #377 - we will resolve all the js/ts icons in one change.

@ofseed
Copy link
Contributor Author

ofseed commented Mar 25, 2024

Even though making icons more consistent is a work in progress, I still want to re-open this issue.
After all, 808627b and 33e27b8 make no sense but a change.

@alex-courtis alex-courtis reopened this Mar 26, 2024
@alex-courtis alex-courtis changed the title revert: revert js, cjs and mjs icon fix: revert js, cjs and mjs to seti icons Mar 26, 2024
@alex-courtis alex-courtis changed the title fix: revert js, cjs and mjs to seti icons foo: revert js, cjs and mjs to seti icons Mar 26, 2024
@alex-courtis alex-courtis changed the title foo: revert js, cjs and mjs to seti icons revert: back to seti: js, cjs and mjs Mar 26, 2024
@alex-courtis alex-courtis merged commit 97b2453 into nvim-tree:master Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants