Add cut,copy and paste functionality. #52
Conversation
kristijanhusak
force-pushed
the
feature/cut-copy-paste
branch
from
85850dd to
9b20fcb
Compare
|
thanks :) I'll review this PR in depth later but it looks already pretty good imo. |
|
I think handling of existing files on copy/move needs to be handled. Now it will just throw an error, but I guess it should prompt for override/cancel. Will try to add it. Edit: Prompt added. |
kristijanhusak
force-pushed
the
feature/cut-copy-paste
branch
from
dd511d0 to
86ff3b7
Compare
kyazdani42
left a comment
kyazdani42
left a comment
There was a problem hiding this comment.
Great work.
I wonder if you could add some kind of popup information or buffer list that would show information about the state of the clipboard ? This could also be done in another PR.
lua/lib/fs.lua
Outdated
| if not success then | ||
| api.nvim_err_writeln('Could not '..action_type..' '..entry.absolute_path..' - '..msg) | ||
| end | ||
| ::continue:: |
There was a problem hiding this comment.
goto is not available for some distributions of neovim (as neovim uses lua 5.1 where goto is not available). You could leave it for now as i still have some piece of code with gotos but this issue will need to be addressed in another PR.
There was a problem hiding this comment.
I changed the logic to not use continue.
|
Yeah I can add something. Maybe echo will be sufficient? |
|
a command would be more appropriate. Echo should be enough indeed |
|
I added |
…paste Add cut,copy and paste functionality.
2 participants
This PR adds cut, copy and paste functionality that I mentioned in issue #51
Note that I don't have much experience with Lua, so do as detailed review as possible.