Fix nvim tree frozen with no name buffer #1879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-courtis
approved these changes
Jan 3, 2023
alex-courtis
added a commit
that referenced
this pull request
Jan 9, 2023
alex-courtis
added a commit
that referenced
this pull request
Jan 9, 2023
…uire_confirm (#1887) * fix(#1878): nvim frozen on no name buffer when modified.enable (#1879) * feat(api): add api.config.mappings.active, api.config.mappings.default (#1876) * feat(api): add config.mappings.current and config.mappings.default * feat(api): add config.mappings.current and config.mappings.default * feat(api): add config.mappings.current and config.mappings.default * Implement turning off y/n prompt for file deletion * Refactor different prompt configs to single ui table * Remove unused fields * add ui.confirm doc, format/tidy * trash.require_confirm -> ui.confirm.trash * Fix nil value trash field Co-authored-by: Richard Li <[email protected]> Co-authored-by: Telman Babayev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1878.
Thanks for raising this one @alex-courtis.
The issue turned out to be path never becoming
cwdor"/"no matter how manyfnamemodify(path, ":h"). This bug would've also appeared if a file out side of the cwd is modified on windows as path would've stopped at"C:\\"instead of"/".I've made it so that:
buf.nameis""fnamemodifydidn't change the path.