-
-
Notifications
You must be signed in to change notification settings - Fork 168
Extend API to get links to headline and org file #768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kristijanhusak
merged 5 commits into
nvim-orgmode:master
from
seflue:api_extension_get_link
Jul 1, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f255ac5
feat(api): Extend API to get links
seflue 5a88955
chore: Remove stale require
seflue 1344eb1
chore: tiny refactoring to align similar methods
seflue 23f0c98
refactor: make get_link member functions
seflue cb621f0
fix: handle unloaded buffers
seflue File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a file path with the title valid format for a file link?
From the examples here https://orgmode.org/guide/Hyperlinks.html I don't see any of those.
I think for link to file it is enough to either be an id, or just
file:/path/to/file.orgif there is no id.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not, and it's also not treated such. I am piggy-backing here on the "title" format to sneak a description into
insert_linkto get the form prefilled.This is something, which actually needs to get cleaned up a bit more properly:
get_linkshould actually return a table or even better an api equivalent ofUrl. Andinsert_linkshould take that. But this would need some more decent refactoring effort which touches a lot of places (think also ofstore_link) so I would prefer to defer this to a separate PR.Right now I am quite happy, how Telescope-orgmode works although the API is not perfect yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, we can leave it for the time being, but later once we do some refactoring, I'd prefer to remove it.
It can also cause side effects in cases where
#+TITLEor the file name is the same as some other headline value. In that case, the link would jump to the headline.