Skip to content
This repository was archived by the owner on Oct 1, 2025. It is now read-only.

Conversation

@vintprox
Copy link
Contributor

Fixes #557

@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #559 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #559   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files          33       33           
  Lines         676      676           
  Branches      207      207           
=======================================
  Hits          670      670           
  Misses          3        3           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32fdb20...0d13612. Read the comment docs.

@pimlie
Copy link
Collaborator

pimlie commented May 11, 2020

Hey, thanks for the quick work!

I was looking at it but doesnt this change also introduce an issue? Because MetaInfo is formost used as input type, so by adding titleChunk to it users might think they can/need to enter that as input. But titleChunk is only available here:

metaInfo: MetaInfo,

So should we add a MetaInfoOutput type maybe that adds the titleChunk?

@vintprox
Copy link
Contributor Author

Hey, thanks for the quick work!

I was looking at it but doesnt this change also introduce an issue? Because MetaInfo is formost used as input type, so by adding titleChunk to it users might think they can/need to enter that as input. But titleChunk is only available here:

metaInfo: MetaInfo,

So should we add a MetaInfoOutput type maybe that adds the titleChunk?

Oh yes, it will do!

@stale
Copy link

stale bot commented Jun 2, 2020

Thanks for your contribution to vue-meta! This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you would like this issue to remain open:

  1. Verify that you can still reproduce the issue in the latest version of vue-meta
  2. Comment the steps to reproduce it
    Issues that are labeled as pending will not be automatically marked as stale.

@stale stale bot added the stale label Jun 2, 2020
@vintprox
Copy link
Contributor Author

vintprox commented Jun 2, 2020

bump

@pimlie pimlie merged commit d947540 into nuxt:master Jun 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MetaInfo interface does not contain titleChunk key

2 participants