Skip to content
This repository was archived by the owner on Oct 1, 2025. It is now read-only.

Conversation

Livog
Copy link
Contributor

@Livog Livog commented Nov 14, 2018

Noticed that sometimes I get an empty object sent here and it makes the vue-meta print out empty tags with no value what so ever. Maybe there is a reason why there is no check for an empty object. I know there should not be empty objects sent here but if something does, it will at least not print empty tags. :)

Let me know if this a good or bad idea.

@TheAlexLichter
Copy link
Member

@Livog Please fix the linting issue ☺️

@codecov
Copy link

codecov bot commented Nov 21, 2018

Codecov Report

Merging #286 into master will decrease coverage by 0.15%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
- Coverage    40.3%   40.15%   -0.16%     
==========================================
  Files          18       18              
  Lines         263      264       +1     
==========================================
  Hits          106      106              
- Misses        157      158       +1
Impacted Files Coverage Δ
src/server/generators/tagGenerator.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ac5d5b...2fe45bb. Read the comment docs.

@atinux atinux merged commit d5a6795 into nuxt:master Nov 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants