This repository was archived by the owner on Oct 1, 2025. It is now read-only.
feat: merge mixins options #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
==========================================
+ Coverage 40.3% 41.57% +1.26%
==========================================
Files 18 18
Lines 263 267 +4
==========================================
+ Hits 106 111 +5
+ Misses 157 156 -1
Continue to review full report at Codecov.
|
TheAlexLichter
suggested changes
Sep 6, 2018
src/shared/getComponentOption.js
Outdated
| if (typeof data === 'object') { | ||
| // merge with existing options | ||
| return deepmerge(result, data, { arrayMerge }) | ||
| } else { |
There was a problem hiding this comment.
When extracting the code into a separate function, you could also get rid of that unnecessary else
There was a problem hiding this comment.
Sure! I'll do that as soon as I'm back home 👍
TheAlexLichter
approved these changes
Sep 6, 2018
|
LGTM! (cc @atinux) |
|
Any news on when this PR can be merged 🙂? |
|
Released to v1.5.4, thanks @adrienbaron |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #261