fix(nuxi): always override NODE_ENV

[danielroe]

🔗 Linked issue

resolves nuxt/nuxt#14057

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds warnings if user is overriding the correct NODE_ENV for build/dev/analyze. (Other commands like preview, typecheck or prepare I felt did not particularly matter, but happy to expand the warnings.)

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[netlify]

✅ Deploy Preview for nuxt3-docs canceled.

Name	Link
🔨 Latest commit	b3e0d66
🔍 Latest deploy log	https://app.netlify.com/sites/nuxt3-docs/deploys/62a65936fdc292000827de05

[pi0]

Thanks for the PR but if we are not recommending custom NODE_ENV, there is no reason to allow overriding it I think. However, it is also worth tracking down what happens with custom env specially for non development builds. It can be simply one or two bugs.

[danielroe]

The cause of nuxt/nuxt#14057 is really a Vite bug (or perhaps it's unfair to say that it's a bug - we could say that Vite does not support building in development mode). Here's how it happens:

1. options.dev is set to true if NODE_ENV is overridden
2. vitejs/plugin-vue injects HMR code because it's not production: https://github.com/vitejs/vite/blob/main/packages/plugin-vue/src/main.ts#L131-L139
3. vite replaces import.meta.hot with false because we're building: https://github.dev/vitejs/vite/blob/main/packages/vite/src/node/plugins/define.ts#L32-L45

I would be very happy with not allowing NODE_ENV to be overridden, but think if we do then we should definitely warn. What was the reason you originally added it (586709a)?

[pi0]

Thanks for explaining! I think we can then change the strategy to override to what we expect but also warn if user already set a NODE_ENV we are overriding and saying hay, we just ignored your env ?