Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): don't terminate with escaped delimiters #5409

Merged
merged 1 commit into from
Jun 10, 2022
Merged

fix(vite): don't terminate with escaped delimiters #5409

merged 1 commit into from
Jun 10, 2022

Conversation

@danielroe
Copy link
Member

🔗 Linked issue

resolves nuxt/nuxt#14097

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This resolves an issue where an escaped quotation was terminating a regexp wrongly.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working vite ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Jun 10, 2022
@danielroe danielroe requested a review from pi0 June 10, 2022 15:12
@danielroe danielroe self-assigned this Jun 10, 2022
@netlify
Copy link

netlify bot commented Jun 10, 2022 •
edited
Loading

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit cef4c0c
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62a35f5e1220300008de0c9f

@pi0 pi0 merged commit 8831e4a into main Jun 10, 2022
@pi0 pi0 deleted the fix/asset-strings branch June 10, 2022 15:17
This was referenced Jun 10, 2022
Closed
Closed
@pi0 pi0 mentioned this pull request Jun 12, 2022
Merged
@danielroe danielroe mentioned this pull request Jun 15, 2022
Closed
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@pi0 pi0 pi0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@danielroe danielroe

Labels

3.x bug Something isn't working ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf vite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failed to parse source for import analysis because the content contains invalid JS syntax

3 participants

@danielroe @pi0