Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

Conversation

@entity
Copy link
Contributor

@entity entity commented May 21, 2022

πŸ”— Linked issue

N/A

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This change improves how the logo is displayed within the README, which utilises GitHubs new light and dark changing. This means we no longer need a white border around the logo, and can better display it automatically.

Preview:
CleanShot 2022-05-21 at 11 08 30@2x
CleanShot 2022-05-21 at 11 11 01@2x

πŸ“ Checklist

  • [] I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented May 21, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit 57731ae
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6288bad30a0d550008016638
😎 Deploy Preview https://deploy-preview-5094--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@entity
Copy link
Contributor Author

entity commented May 21, 2022

To further explain, this is how it currently looks:
CleanShot 2022-05-21 at 11 12 14@2x

@ASISBusiness
Copy link

πŸ”— Linked issue

N/A

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)

  • 🐞 Bug fix (a non-breaking change that fixes an issue)

  • πŸ‘Œ Enhancement (improving an existing functionality like performance)

  • ✨ New feature (a non-breaking change that adds functionality)

  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This change improves how the logo is displayed within the README, which utilises GitHubs new light and dark changing. This means we no longer need a white border around the logo, and can better display it automatically.

Preview:

CleanShot 2022-05-21 at 11 08 30@2x CleanShot 2022-05-21 at 11 11 01@2x

πŸ“ Checklist

  • [] I have linked an issue or discussion.

  • I have updated the documentation accordingly.

@atinux atinux self-requested a review May 23, 2022 09:58
@atinux atinux merged commit 7149961 into nuxt:main May 23, 2022
@pi0 pi0 mentioned this pull request Jun 10, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants