This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): add default empty title to trigger titleTemplate
#5064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
added
bug
✅ Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
7 tasks
pi0
approved these changes
May 20, 2022
There was a problem hiding this comment.
LGTM. Only as discussed with @danielroe it causes an empty <title> tag which could be improved.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
nuxt/nuxt#13981
❓ Type of change
📚 Description
Previously a
titleTemplatewould only be used if there was also atitleset (even if empty). This PR adds a basic empty title that can be overridden, meaning that titleTemplate works.📝 Checklist