This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(webpack): respect build.transpile
#5043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
added
bug
✅ Deploy Preview for nuxt3-docs canceled.
|
pi0
reviewed
May 20, 2022
packages/webpack/src/presets/nuxt.ts
Outdated
| export function nuxt (ctx: WebpackConfigContext) { | ||
| applyPresets(ctx, [ | ||
| base, | ||
| baseTranspile, |
There was a problem hiding this comment.
We could directly use baseTranspile in base preset. Also I believe there was some leftover issues that didn't add transpile to the base on initial rewrite.
There was a problem hiding this comment.
Do you recall what those issues were?
There was a problem hiding this comment.
Not precisely (other than TODO comment with unique in the code). Any way we can test that only I believe it had to be in the base. I exported it back in the time since wasn't sure about legacy+modern transpile but we now effectively have one target.
7 tasks
pi0
changed the title
build.transpile
|
Pending merge to double-check |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Extracted from #5042, this PR respects user's
build.transpilefor forcing transpilation on files innode_modules.📝 Checklist