This repository was archived by the owner on Apr 6, 2023. It is now read-only.
-
-
Couldn't load subscription status.
- Fork 1k
fix(nuxt): don't debounce watcher, and include layers #5002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β Deploy Preview for nuxt3-docs canceled.
|
atinux
approved these changes
May 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! It is also a great DX improvement for theme authors.
7 tasks
pi0
reviewed
May 31, 2022
Merged
pi0
approved these changes
Jun 10, 2022
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
3.x
bug
Something isn't working
π¨ p3-minor-bug
Priority 3: a bug in an edge case that only affects very specific usage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves nuxt/nuxt#13791, resolves nuxt/nuxt#14053
β Type of change
π Description
In some circumstances the watcher was swallowing 'add' events, causing nuxt/nuxt#13791 (not just on Windows), because it was debouncing an add + change event into a single change event. This PR removes the debouncing on the watcher, as we already have a debouncer on the
generateAppfunction. (But alternative suggestions welcome.)This PR also adds layers to the watch sources, and slightly tightens what paths trigger a regeneration of the app. Layers will be excluded automatically if they are in node_modules, of course, so the effect is only to include base layers within a monorepo.
π Checklist