Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

Conversation

@jeremyeo
Copy link
Contributor

@jeremyeo jeremyeo commented May 13, 2022

πŸ”— Linked issue

nuxt/nuxt#13980

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented May 13, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit bb20ba7
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/627e287d353c450008f5a230

@danielroe
Copy link
Member

Would it be worth using pathToFileURL instead?

await fse.writeFile(
resolve(ctx.nuxt.options.buildDir, 'dist/server/server.mjs'),
`export { default } from ${JSON.stringify(resolve(distDir, 'runtime/vite-node.mjs'))}`
`export { default } from ${JSON.stringify('file://' + resolve(distDir, 'runtime/vite-node.mjs'))}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might use pathToFileURL

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 changed the title fix(vite): on win, add file:// protocol to vite-node entry file path fix(vite): add file:// protocol to vite-node entry file path May 13, 2022
@pi0 pi0 merged commit bd80d27 into nuxt:main May 13, 2022
@pi0 pi0 mentioned this pull request Jun 10, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants