Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

Conversation

@danielroe
Copy link
Member

πŸ”— Linked issue

follow up on #3898

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

this defines the meta mixin outside the plugin so we can add the installed flag in bridge...

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working bridge πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Mar 25, 2022
@danielroe danielroe requested a review from pi0 March 25, 2022 12:42
@danielroe danielroe self-assigned this Mar 25, 2022
@pi0
Copy link
Member

pi0 commented Mar 25, 2022

Since we are already guarding bridge-compat, is this change necessary?

@danielroe
Copy link
Member Author

The issue is that the mixin object is defined inline, which means the __nuxt_installed flag is set freshly each time, and it can't deduplicate. By moving it out of function, we get the protection applied.

@netlify
Copy link

netlify bot commented Mar 25, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit fa684f8
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/623dbaa030b5f400092731d9

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bridge bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants