Skip to content

fix(highlight): remove @nuxt/kit from runtime bundle #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2022
Merged

fix(highlight): remove @nuxt/kit from runtime bundle #1346

merged 1 commit into from
Jul 11, 2022

Conversation

@farnabaz
Copy link
Member

@farnabaz farnabaz commented Jul 11, 2022

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jul 11, 2022 •
edited
Loading

✅ Deploy Preview for nuxt-content ready!

Name Link
🔨 Latest commit 5f90b99
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/62cbf82d72a56d0008286afe
😎 Deploy Preview https://deploy-preview-1346--nuxt-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@farnabaz farnabaz merged commit 772f48f into main Jul 11, 2022
@farnabaz farnabaz deleted the fix/rm-nuxt-kit branch July 11, 2022 10:32
@pi0
Copy link
Member

pi0 commented Jul 11, 2022

/cc @danielroe Can you please investigate why this wasn't caught with import protection?

@danielroe danielroe mentioned this pull request Jul 12, 2022
Merged
7 tasks
@danielroe
Copy link
Member

danielroe commented Jul 12, 2022

~> nitrojs/nitro#335

@danielroe danielroe mentioned this pull request Jul 12, 2022
Merged
7 tasks
@farnabaz farnabaz mentioned this pull request Aug 12, 2022
Merged
farnabaz added a commit that referenced this pull request Sep 7, 2022
@farnabaz
fix(highlight): remove @nuxt/kit from runtime bundle (#1346)
f846ddc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atinux atinux atinux approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@farnabaz @pi0 @danielroe @atinux