Skip to content

Conversation

@harlan-zw
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I wanted to modify the query for a <ContentNavigation>, the docs specify you can provide a type of QueryBuilderParams. When typing a QueryBuilderParams though, it requires all fields to be provided.

I could get around this using Partial, but better to accurately represent the params, it's not guaranteed that any specific key will be available.

image

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jun 3, 2022

‼️ Deploy request for nuxt-content rejected.

Name Link
πŸ”¨ Latest commit 5c9f6ca

@Tahul
Copy link
Contributor

Tahul commented Jun 3, 2022

You are totally right, I've also encountered that problem before and I'm so happy you fixed it!

Thanks a lot!

@Tahul Tahul merged commit 32d5236 into nuxt:main Jun 3, 2022
@farnabaz farnabaz mentioned this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants