Skip to content

fix: only set 404 status on SSR #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2022
Merged

fix: only set 404 status on SSR #618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions pages/[...slug].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script setup lang="ts">
import { computed, useContent, useHead, useTheme } from '#imports'
import { computed, useContent, useHead, useRequestEvent, useTheme } from '#imports'

definePageMeta({
/* Layout transitions creates layout shifts with defaults */
Expand All @@ -10,14 +10,10 @@ definePageMeta({
const { page } = useContent()
const theme = useTheme()

// Page not found
if (!page.value) {
throwError(
createError({
statusCode: 404,
statusMessage: `Page not found: ${useRoute().path}`,
}),
)
// Page not found, set correct status code on SSR
if (!page.value && process.server) {
const event = useRequestEvent()
event.res.statusCode = 404
}

const cover = computed(() => {
Expand Down