fix(deps)!: make @sentry/webpack-plugin a peer dependency #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: To use the "publishRelease" option, it's now necessary to manually install the @sentry/webpack-plugin package as a dev dependency.
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
=======================================
Coverage 71.42% 71.42%
=======================================
Files 1 1
Lines 49 49
Branches 23 23
=======================================
Hits 35 35
Misses 11 11
Partials 3 3 Continue to review full report at Codecov.
|
Member
Author
|
While Sentry reverted their change, it is still technically more correct to list |
* origin/master: fix(deps): update dependency @sentry/webpack-plugin to ^1.18.7 (#392)
rchl
added a commit
that referenced
this pull request
Feb 20, 2022
BREAKING CHANGE: To use the "publishRelease" option, it's now necessary to manually install the `@sentry/webpack-plugin` package as a dev dependency.
rchl
added a commit
that referenced
this pull request
Aug 3, 2022
BREAKING CHANGE: Make `@sentry/webpack-plugin` a peer dependency. To use the "publishRelease" option, it's now necessary to manually install that package as a dev dependency.
rchl
added a commit
that referenced
this pull request
Aug 3, 2022
…390) BREAKING CHANGE: Don't ship with `@sentry/webpack-plugin` as a dependency. To use the "publishRelease" option, it's now necessary to manually install that package as a dev dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: To use the "publishRelease" option, it's now necessary to manually install the
@sentry/webpack-pluginpackage as a dev dependency.This is in response to Sentry change getsentry/sentry-webpack-plugin#343 which inadvertently made webpack dependencies get installed in production.