fix: don't pass empty object to integrations constructor #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some context in getsentry/sentry-javascript#4186 which shows that passing empty object to some integrations (ExtraErrorData for example) will make it not assume default values for some options.
Codecov Report
@@ Coverage Diff @@
## master #376 +/- ##
=======================================
Coverage 74.46% 74.46%
=======================================
Files 1 1
Lines 47 47
Branches 21 21
=======================================
Hits 35 35
Misses 9 9
Partials 3 3 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some context in getsentry/sentry-javascript#4186
which shows that passing empty object to some integrations (ExtraErrorData
for example) will make it not assume default values for some options.