Skip to content

Conversation

juntyr
Copy link
Contributor

@juntyr juntyr commented Jul 26, 2025

  • Implements the fmin and fmax ufuncs
  • Unblocks using np.nanmin and np.nanmax

@juntyr juntyr marked this pull request as draft July 26, 2025 14:43
@juntyr juntyr marked this pull request as ready for review July 27, 2025 15:23
@juntyr
Copy link
Contributor Author

juntyr commented Jul 27, 2025

?r @SwayamInSync

@SwayamInSync
Copy link
Member

Thanks @juntyr , I wonder registering quad_minimum/maximum with fmin fmax ufuncs would've also worked?

@juntyr
Copy link
Contributor Author

juntyr commented Jul 27, 2025

Thanks @juntyr , I wonder registering quad_minimum/maximum with fmin fmax ufuncs would've also worked?

No, they have different NaN propagation behaviour. minimum/maximum propagates NaNs, fmin/fmax tries to avoid propagating them

@SwayamInSync
Copy link
Member

No, they have different NaN propagation behaviour. minimum/maximum propagates NaNs, fmin/fmax tries to avoid propagating them

Ah yes I just noticed, thanks merging it

@SwayamInSync SwayamInSync merged commit 8fde328 into numpy:main Jul 27, 2025
6 checks passed
@juntyr juntyr deleted the fmin-fmax branch July 27, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants