Skip to content

ENH: nper: Perform C division where appropriate #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2024
Merged

ENH: nper: Perform C division where appropriate #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions numpy_financial/_cfinancial.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,16 @@ cdef double nper_inner_loop(
return INFINITY

if rate_ == 0.0:
return -(fv_ + pv_) / pmt_
with cython.cdivision(True):
# We know that pmt_ != 0, we don't need to check for division by 0
return -(fv_ + pv_) / pmt_

if rate_ <= -1.0:
return NAN

z = pmt_ * (1.0 + rate_ * when_) / rate_
with cython.cdivision(True):
# We know that rate_ != 0, we don't need to check for division by 0
z = pmt_ * (1.0 + rate_ * when_) / rate_
return log((-fv_ + z) / (pv_ + z)) / log(1.0 + rate_)


Expand Down