-
-
Notifications
You must be signed in to change notification settings - Fork 239
Transfer axis label colors #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I am going to fix the tests next week ;) |
What are these dockerfiles? |
Sorry, my mistake. I develop in containers and usually keep the dockerfiles in my gitignore. Obviously forgot it this time. I just removed them. |
There is another weird file. |
Removed. But this is nothing that is introduced by my changes. This file is reproducibly generated by running tox, even on main. Thats why i left it there. I added it to the gitignore so no one else commits it by mistake. |
... and another one. |
... and again, these file are generated by running the unittests in general, they have nothing to do with this PR. |
What's the label color by default? |
Tikz and matplotlib use |
I understand. I would probably lean towards "explicit is better than implicit" nowadays, too, but tikzplotlib has made a choice years ago to not include code that's default anyway. The idea was to keep the output TeX file reasonably lean. I would hence suggest to only include the color spec if it's not |
LGTM now. Thanks! |
As of now the color of axis labels is not considered in the tikz output. This small change fixes this.