[nrf fromlist] modules: hal_nordic: nrfx: make NRFX_SPI(M/S) selectable #3420
Conversation
mstasiaknordic
force-pushed
the
nrfx_spim_spis
branch
from
1f91ab6 to
35d7df0
Compare
mstasiaknordic
requested review from
magp-nordic,
masz-nordic and
nika-nordic
mstasiaknordic
force-pushed
the
nrfx_spim_spis
branch
from
35d7df0 to
492a422
Compare
Since selectable per-instance configs are removed, allow selecting the general symbol for driver. Upstream PR #: 96792 Signed-off-by: Michał Stasiak <[email protected]>
mstasiaknordic
force-pushed
the
nrfx_spim_spis
branch
from
492a422 to
2667add
Compare
| bool "SPIM driver" | ||
| depends on $(dt_has_compat,$(DT_COMPAT_NORDIC_NRF_SPIM)) | ||
|
|
||
| DT_COMPAT_NORDIC_NRF_SPIS := nordic,nrf-spis |
There was a problem hiding this comment.
Why can't it be passed directly?
There was a problem hiding this comment.
I believe it is due to commas in compat name, it is the recommended way https://github.com/zephyrproject-rtos/zephyr/blob/a8bf08bf4e2f43ab915ae35b0a4e7418f7f978a8/scripts/dts/gen_driver_kconfig_dts.py#L25-L29
There was a problem hiding this comment.
Also, an alternative to dt_has_compat would be dt_compat_enabled. We allow using NRFX driver if the HW is there (indicated by presence of node with compat) but IMO the node does not have to be enabled
There was a problem hiding this comment.
I am looking at the definitions of HAS_HW_NRF and I see they use DT_COMPAT_NORDIC_NRF_ without it being defined (probably because of what you sent). Maybe those symbols do not need to be defined?
I will approve anyway; I do not want to block it, but I have a feeling someone might comment on this when we try to merge the collab into main.
4 participants
Since selectable per-instance configs are removed, allow selecting the general symbol for driver.
Upstream PR #: 96792