Skip to content

Conversation

@ioannisg
Copy link
Contributor

@ioannisg ioannisg commented Nov 18, 2019

Contains the following patches

  • From tree:
    • Enable DCDC
    • Fix CACHE and NVMC macros
    • [BLE] buffer init after allocation
  • From list:
  • Revert Local temp-hacks:
    • Remove setting the default controller to LEGACY

Johan Hedberg and others added 4 commits November 18, 2019 23:21
The code was not properly taking into account CONFIG_BT_HCI_RESERVE,
which would cause buffer underruns for any HCI driver where this value
defaults to non-zero. Also, all the allocation functions use the same
pool, so we can map them simply to bt_buf_get_rx() instead of
repeating the same code.

Signed-off-by: Johan Hedberg <[email protected]>
Signed-off-by: Ioannis Glaropoulos <[email protected]>
Since the nRF5340 DK contains the required DC/DC circuitry,
enable it by default while keeping it configurable. This
reduces power consumption in application core , network
core and high voltage use.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Signed-off-by: Ioannis Glaropoulos <[email protected]>
…usage

We need to fix the formato of the macros for nRF CACHE and NVMC
peripherals in soc.c, so the _S and _NS suffixes are skipped.

Signed-off-by: Ioannis Glaropoulos <[email protected]>
…tions relative

A partition start offsets should be expressed relative to the flash
device base address. For cpunet flash partitions start offsets
were improperly expressed as absolute flash address.

This patch fixes partitions start addresses for nRF5340 cpunet.

Signed-off-by: Andrzej Puzdrowski <[email protected]>
Signed-off-by: Ioannis Glaropoulos <[email protected]>
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 18, 2019

Some checks failed. Please fix and resubmit.

checkpatch (informational only, not a failure)

-:108: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#108: FILE: boards/arm/nrf5340_dk_nrf5340/nrf5340_dk_nrf5340_shared_sram_planning_conf.dts:15:
+    chosen {$

-:110: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#110: FILE: boards/arm/nrf5340_dk_nrf5340/nrf5340_dk_nrf5340_shared_sram_planning_conf.dts:17:
+      zephyr,ipc_shm = &sram0_shared;$

-:111: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#111: FILE: boards/arm/nrf5340_dk_nrf5340/nrf5340_dk_nrf5340_shared_sram_planning_conf.dts:18:
+    };$

- total: 0 errors, 3 warnings, 1818 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Gitlint issues

Commit 7898118:
1: UC5 Title exceeds max length (83>75): "[nrf fromlist] boards/arm/nrf5340_dk_nrf5340: make cpunet flash partitions relative"

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@ioannisg ioannisg requested a review from cvinayak as a code owner November 18, 2019 23:07
@ioannisg
Copy link
Contributor Author

@kapi-no can you test that the setup still works now that we moved this to NCS?

@kapi-no
Copy link
Contributor

kapi-no commented Nov 19, 2019

@ioannisg, yes, sure.

Could you open matching PR to the nrf repository (with west manifest pointing to this PR)?

This commit squashes into one the commits of the upstream
project pull request 20467, which brings support of BLE HCI
controller in nRF5340 over openAMP transport.

Signed-off-by: Ioannis Glaropoulos <[email protected]>
This reverts commit 22e7108.

Signed-off-by: Ioannis Glaropoulos <[email protected]>
Default the BLE Controller to the SPLIT architecture.

Signed-off-by: Ioannis Glaropoulos <[email protected]>
@carlescufi carlescufi merged commit 7e20180 into nrfconnect:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants