Skip to content

fix(arborist): do not audit in offline mode #4410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2022
Merged

fix(arborist): do not audit in offline mode #4410

merged 1 commit into from
Feb 16, 2022

Conversation

mohd-akram
Copy link
Contributor

Disables audit in offline mode.

References

Fixes #4368

@mohd-akram mohd-akram requested a review from a team as a code owner February 14, 2022 09:05
nlf
nlf approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! this is great!

@ruyadorno ruyadorno added Release 8.x work is associated with a specific npm 8 release release: next These items should be addressed in the next release semver:patch semver patch level for changes labels Feb 15, 2022
@wraithgar wraithgar changed the base branch from latest to release-next February 16, 2022 16:37
@wraithgar wraithgar merged commit 54cda96 into npm:release-next Feb 16, 2022
@mohd-akram mohd-akram deleted the fix-offline-audit branch February 16, 2022 16:46
@fritzy fritzy mentioned this pull request Feb 17, 2022
Merged
@lpinca lpinca mentioned this pull request Feb 18, 2022
Merged
@lukekarrys lukekarrys mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

@nlf nlf nlf approved these changes

@darcyclarke darcyclarke darcyclarke approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release: next These items should be addressed in the next release Release 8.x work is associated with a specific npm 8 release semver:patch semver patch level for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] npm install hangs in offline mode due to trying to run audit
5 participants
@mohd-akram @ruyadorno @nlf @darcyclarke @wraithgar