ci: delete the contents of node_modules only, not the directory #2083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlf
force-pushed
the
nlf/delete-contents-not-dir
branch
from
e365961 to
f00d475
Compare
darcyclarke
approved these changes
Oct 29, 2020
darcyclarke
added
Release 7.x
ljharb
reviewed
Oct 29, 2020
| @@ -31,7 +31,7 @@ const ci = async () => { | |||
| 'later to generate a package-lock.json file, then try again.' | |||
| throw new Error(msg) | |||
| }), | |||
| rimraf(`${where}/node_modules/`), | |||
| rimraf(`${where}/node_modules/*`, { glob: { dot: true, nosort: true, silent: true } }), | |||
There was a problem hiding this comment.
does this include .bin and other dotfiles?
There was a problem hiding this comment.
yes! the default options passed to glob from rimraf are { nosort: true, silent: true } adding dot: true is the effective change here, which per glob's documentation:
You can make glob treat dots as normal characters by setting dot:true in the options.
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes it so that instead of deleting the entire node_modules directory, we instead delete only its contents. this used to be the case in npm 6 and the current state of things is a regression.