Skip to content

Unit test config commands + fixes and refactors #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Unit test config commands + fixes and refactors #2001

wants to merge 2 commits into from

Conversation

ruyadorno
Copy link
Contributor

@ruyadorno ruyadorno commented Oct 21, 2020 •
edited
Loading

  • Add unit tests for lib/config.js
  • Small refactors such as line breaks and favor usage of flatOptions
  • Removes validBefore? console.error msg
  • Fixes typos

@ruyadorno ruyadorno requested a review from a team as a code owner October 21, 2020 04:30
@ruyadorno ruyadorno force-pushed the unit-test-config-commands branch 4 times, most recently from 5332793 to 5ddedcf Compare October 21, 2020 21:04
@ruyadorno ruyadorno changed the title Unit test config commands Unit test config commands + fixes and refactors Oct 21, 2020
@ruyadorno ruyadorno mentioned this pull request Oct 21, 2020
Closed
@ruyadorno ruyadorno self-assigned this Oct 21, 2020
@ruyadorno ruyadorno added this to the OSS - Sprint 18 milestone Oct 21, 2020
@ruyadorno ruyadorno added Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes labels Oct 21, 2020
@ruyadorno ruyadorno linked an issue Oct 21, 2020 that may be closed by this pull request
unit tests for config commands #1501
Closed
@ruyadorno ruyadorno mentioned this pull request Oct 22, 2020
Closed
@darcyclarke darcyclarke added the release: next These items should be addressed in the next release label Oct 23, 2020
@ruyadorno
fix: npm config
b4972a7 
- Small refactors such as line breaks and favor usage of flatOptions
- Removes validBefore? console.error msg
- Fix typos
@ruyadorno ruyadorno force-pushed the unit-test-config-commands branch from 5ddedcf to b4972a7 Compare October 23, 2020 17:00
@isaacs isaacs closed this in 39ad1ad Oct 23, 2020
@lpinca lpinca mentioned this pull request Nov 1, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ruyadorno ruyadorno

Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Milestone
OSS - Sprint 18
Development

Successfully merging this pull request may close these issues.

unit tests for config commands
2 participants
@ruyadorno @darcyclarke