Skip to content

[Backport] Tierprice can t save float percentage value 18651 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

novikor
Copy link
Owner

@novikor novikor commented May 16, 2019

Original Pull Request

magento#19584

Description (*)

See magento#18651

Fixed Issues (if relevant)

  1. Tierprice can't save float percentage value magento/magento2#18651: Tierprice can't save float percentage value

Manual testing scenarios (*)

Steps to reproduce (*)

  1. Add new product
  2. Add new tierprice with "discount" value "12.5"
  3. Save the product

Expected result (*)

  1. Saving the tierprice as you set it "12.5"

Actual result (*)

  1. It's converted to INT then save it

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@novikor novikor closed this May 18, 2019
novikor pushed a commit that referenced this pull request Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants