fix bug with multiple columns in same metric #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When querying postgres `pg_runtime_variable`, postgres might return -1 for `max_standby_archive_delay` and `max_standby_streaming_delay`
This simply pulls and runs postgres against a number of versions and checks that we can successfully connect to it.
Add docker based integration test suite.
Parse strings to floats
…_handling Handle `pg_runtime_variable` return values
Update to use common/log
…eing used because the map was being overwritten each time); add -dumpmaps option for debugging
Owner
|
Excellent! |
Author
|
No, thank you! You did 99% of the work, I just fixed a bug. |
Owner
|
^_^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the last column in each metric was being used because the map was being overwritten each time. Also added a dumpmaps option for debugging to help demonstrate the problem.