fix: reverse the parameter order when invoking #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it possible for functions to easily act as both HTTP and CloudEvent handler it's better to have any potential data as the second parameter. This change also makes use of a new bit of the cloudevents API to receive an incoming event, eliminating a transitive dependency on axios. Fixes: nodeshift#62 Fixes: knative/func#194 (when updated in thetemplate) Signed-off-by: Lance Ball <[email protected]>
matejvasek
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it possible for functions to easily act as both HTTP and CloudEvent
handler it's better to have any potential data as the second parameter.
This change also makes use of a new bit of the cloudevents API to receive an
incoming event, eliminating a transitive dependency on axios.
Fixes: #62
Fixes: knative/func#194 (when updated in thetemplate)
BREAKING CHANGE
Signed-off-by: Lance Ball [email protected]