Skip to content

Mitigate target="_blank" vulnerability #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2016
Merged

Mitigate target="_blank" vulnerability #538

merged 1 commit into from
Oct 22, 2016

Conversation

@jpwesselink
Copy link
Member

@jpwesselink jpwesselink commented Oct 21, 2016

No description provided.

This was referenced Oct 21, 2016
Open
Closed
@riyadhalnur riyadhalnur self-assigned this Oct 22, 2016
@riyadhalnur
Copy link
Member

riyadhalnur commented Oct 22, 2016 •
edited
Loading

The rel fix is a mitigation if we open new tabs/windows for links. Otherwise, it really doesn't matter. Instead of nuking target="_blank", it should actually be target="_blank" rel="noopener noreferrer"

@jpwesselink jpwesselink force-pushed the bugfix/mitigate-target-blank-vulnerability branch from cf455f0 to 7b1fb48 Compare October 22, 2016 09:08
@jpwesselink
Copy link
Member Author

jpwesselink commented Oct 22, 2016

Thanks for pointing that out, should be fixed now.

@riyadhalnur riyadhalnur merged commit 70c5762 into nodeschool:source Oct 22, 2016
@riyadhalnur
Copy link
Member

riyadhalnur commented Oct 22, 2016

Thank you! Merged 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@riyadhalnur riyadhalnur riyadhalnur approved these changes

Assignees

@riyadhalnur riyadhalnur

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpwesselink @riyadhalnur