-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
chore(download): remove dead page #8174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Aviv Keller <[email protected]>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes a dead documentation page that provides installation instructions for Node.js via various package managers. The page had no backlinks, making it safe to delete as part of code cleanup.
- Removes the entire package manager installation guide file
- Eliminates unused documentation content
- Cleans up the codebase by removing orphaned files
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8174 +/- ##
=======================================
Coverage 76.58% 76.59%
=======================================
Files 115 115
Lines 9602 9614 +12
Branches 322 323 +1
=======================================
+ Hits 7354 7364 +10
- Misses 2247 2249 +2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
We had a PR 3 weeks ago (#8114), so it seems like some folks are finding this page? |
You can find the page via google search with specific terms, but it'll rarely show up since there are zero backlinks to this page. Thus, I think, it has little value. |
Bump @nodejs/web |
I wouldn't it call dead. It's supposed to be sunset with the Download Archive page, now as it got merged I wonder if we can sunset this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm neutral, approving. But can foresee people crying about this. Should we maybe just mark it as archived with a banner on the top?
I think it's fine to remove, but I maybe worth adding a temporary redirect to the new downloads page so that any users who still have this link aren't completely lost (I'd prefer this to keeping the page around with an added warning) |
How about:
|
Can we look at analytics to see what the traffic is here? If it's significant I'd be more inclined to go with a banner, but if it's only a limited set of users from old links, I'd vote for just doing a redirect given the new pages have existed for a while now. |
Had a quick look at analytics, this route has had ~290k views in the last year, ~11k in the last 30 days. Top referrer by far (~180k of the ~290k) is Google. More traffic than I was expecting for sure, but I still dislike the idea of keeping a page around that we're not maintaining, that feels like risking misinforming users (and AI bots scraping our pages). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have strong opinion but there are some installation methods that we may want on download page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since users are still using this page, I think a temporary redirect would be a better choice.
Got it, I'll add a redirect as well, we can always remove it later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There are no backlinks to this page, and thus, it should be fine to delete.