Skip to content

fix(blog): format old blog posts #8071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

fix(blog): format old blog posts #8071

merged 1 commit into from
Aug 15, 2025

Conversation

avivkeller
Copy link
Member

@avivkeller avivkeller commented Aug 12, 2025

Blocking #8057.

The blog posts before the migration don't properly escape what needs to be escaped. This PR fixes that.

Copy link

vercel bot commented Aug 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Updated (UTC)
nodejs-org Ready Preview Aug 12, 2025 3:00pm

@avivkeller
Copy link
Member Author

84 down, 311 to go!

Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.82%. Comparing base (d232912) to head (7c1c484).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8071      +/-   ##
==========================================
+ Coverage   72.81%   72.82%   +0.01%     
==========================================
  Files          96       96              
  Lines        8328     8328              
  Branches      214      214              
==========================================
+ Hits         6064     6065       +1     
+ Misses       2263     2262       -1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

@avivkeller avivkeller marked this pull request as ready for review August 12, 2025 14:59
@Copilot Copilot AI review requested due to automatic review settings August 12, 2025 14:59
@avivkeller avivkeller requested a review from a team as a code owner August 12, 2025 14:59
@avivkeller avivkeller force-pushed the format-old-blog-posts branch from d54af01 to 7c1c484 Compare August 12, 2025 14:59
@avivkeller avivkeller requested review from a team as code owners August 12, 2025 14:59
@avivkeller avivkeller changed the title [WIP] fix(blog): format old blog posts fix(blog): format old blog posts Aug 12, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses escaping issues in Node.js release blog posts written before the migration. The changes ensure that markdown content that needs to be escaped is properly handled, specifically focusing on bracketed commit references in changelog sections.

  • Replaces unescaped square brackets with escaped backslash notation in commit references
  • Updates formatting in three v10.x release blog posts to maintain consistency
  • Ensures proper markdown rendering for older blog post content

Reviewed Changes

Copilot reviewed 62 out of 395 changed files in this pull request and generated 1 comment.

File Description
v10.9.0.md Escapes square brackets in 164 commit reference lines in the changelog section
v10.8.0.md Escapes square brackets in 93 commit reference lines in the changelog section
v10.7.0.md Escapes square brackets in 121 commit reference lines in the changelog section

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to approve a PR when I have no idea which of these changes were done manually by you (like the first file) and whose are automated ones...

I'd suggest separating these two in different commits

@avivkeller
Copy link
Member Author

It's hard to approve a PR when I have no idea which of these changes were done manually by you (like the first file) and whose are automated ones...

I'd suggest separating these two in different commits

The only major manual change was the first file. Everything else was automatically formatted via remark stringifying the content, and then manually fixed (i.e. if something that should not have been escaped was escaped)

@ovflowd ovflowd merged commit 435984b into main Aug 15, 2025
10 checks passed
@ovflowd ovflowd deleted the format-old-blog-posts branch August 15, 2025 12:22
@ovflowd
Copy link
Member

ovflowd commented Aug 15, 2025

Bypassing Rules. Releasers don't need to approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants