-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix(blog): format old blog posts #8071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
84 down, 311 to go! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8071 +/- ##
==========================================
+ Coverage 72.81% 72.82% +0.01%
==========================================
Files 96 96
Lines 8328 8328
Branches 214 214
==========================================
+ Hits 6064 6065 +1
+ Misses 2263 2262 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
d54af01
to
7c1c484
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses escaping issues in Node.js release blog posts written before the migration. The changes ensure that markdown content that needs to be escaped is properly handled, specifically focusing on bracketed commit references in changelog sections.
- Replaces unescaped square brackets with escaped backslash notation in commit references
- Updates formatting in three v10.x release blog posts to maintain consistency
- Ensures proper markdown rendering for older blog post content
Reviewed Changes
Copilot reviewed 62 out of 395 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
v10.9.0.md | Escapes square brackets in 164 commit reference lines in the changelog section |
v10.8.0.md | Escapes square brackets in 93 commit reference lines in the changelog section |
v10.7.0.md | Escapes square brackets in 121 commit reference lines in the changelog section |
apps/site/pages/en/blog/npm/managing-node-js-dependencies-with-shrinkwrap.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to approve a PR when I have no idea which of these changes were done manually by you (like the first file) and whose are automated ones...
I'd suggest separating these two in different commits
The only major manual change was the first file. Everything else was automatically formatted via remark stringifying the content, and then manually fixed (i.e. if something that should not have been escaped was escaped) |
Bypassing Rules. Releasers don't need to approve. |
Blocking #8057.
The blog posts before the migration don't properly escape what needs to be escaped. This PR fixes that.