fix: remove confusing close label for navigation menu #7463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
AugustinMauroy
left a comment
AugustinMauroy
left a comment
There was a problem hiding this comment.
maybe something like toggle ?
Contributor
Author
I don't understand your comment, can you clarify? |
aduh95
commented
Feb 6, 2025
Signed-off-by: Antoine du Hamel <[email protected]>
github-actions
bot
removed
the
github_actions:pull-request
Contributor
|
Lighthouse Results
|
Contributor
Unit Test Coverage Report
Unit Test Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As I was trying around navigating the website with VoiceOver, I noticed the current design is kinda confusing:
TBH I'm not at all confident which version is the correct one, if someone who are a screen reader user could chime in, that'd be much appreciated.
An alternative would be to use a more verbose label (such as "Navigation menu is currently closed, tick the box to open it", and "Navigation menu is currently open, untick the box to close it"), not sure if this is preferable.
Validation
Related Issues
#7427
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.