Skip to content

Conversation

@stefanseeger
Copy link

@stefanseeger stefanseeger commented Jan 24, 2025

Remove winget from documentation because it is unreliable

Description

NodeJS versions are unreliably published to winget. Therefore, this reference falsy gives the impression that it will contain the latest versions.

Validation

Current LTS is 22.13.1
Image

which is non existing

winget install --id=OpenJS.NodeJS -v "22.13.1" -e
No version found matching: 22.13.1

Result of change

image

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Remove winget from documentation because it is unreliable

Signed-off-by: stefanseeger <[email protected]>
@stefanseeger stefanseeger requested a review from a team as a code owner January 24, 2025 08:15
@vercel
Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jan 24, 2025 8:24am

other languages
@github-actions
Copy link
Contributor

Note

Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project.
We recommend giving a read on our Translation Guidelines.

Thank you!

@stefanseeger stefanseeger changed the title Fix #7416 Fix #7416 - Removes winget from documentation because of unreliability Jan 24, 2025
@stefanseeger stefanseeger changed the title Fix #7416 - Removes winget from documentation because of unreliability docs: #7416 - Removes winget from documentation because of unreliability Jan 24, 2025
@AugustinMauroy
Copy link
Member

Do not change translation because it's handle by crowdin.

@AugustinMauroy
Copy link
Member

AugustinMauroy commented Jan 24, 2025

also why not put winged on "main" download page ?

cc @ovflowd

@aduh95
Copy link
Contributor

aduh95 commented Jan 24, 2025

I’m not sure we have enough information to claim winger is unreliable, it looks like the latest LTS should be available as it was added in microsoft/winget-pkgs#214141.

@stefanseeger
Copy link
Author

Okay, I think now I understand what is happening.
OpenJS.NodeJS.LTS contains only the LTS versions.
OpenJS.NodeJS other versions?

But even for OpenJS.NodeJS.LTS I'm missing the patched LTS 20.18.2 only 20.18.0 is available.

Obviously I will close this PR, but I still think that this versioning is confusing and the published versions are incomplete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants