Use console.error() for errors consistently #7411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In all examples in this document errors are logged by using `console.error()` method And it's unclear why in promise-based part we have different strategy Signed-off-by: Artem Dragunov <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mikeesto
approved these changes
Jan 18, 2025
AugustinMauroy
approved these changes
Jan 18, 2025
bmuenzenmeyer
approved these changes
Jan 18, 2025
ovflowd
approved these changes
Jan 18, 2025
aymen94
approved these changes
Jan 20, 2025
github-actions
bot
removed
the
github_actions:pull-request
Contributor
|
Lighthouse Results
|
Contributor
Unit Test Coverage Report
Unit Test Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all examples in this document errors are logged by using
console.error()methodAnd it's unclear why in promise-based part we have different strategy
Description
Validation
Related Issues
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.