fix: compatibility engine should run even on initial state #7366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
removed
the
github_actions:pull-request
Contributor
|
Lighthouse Results
|
Contributor
Unit Test Coverage Report
Unit Test Report
|
github-actions
bot
removed
the
github_actions:pull-request
ljharb
approved these changes
Dec 28, 2024
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
This addresses the issue with AIX being available on initial load, but it'd be good to have tests :-) (here or in a followup)
ovflowd
added
fast-track
github-actions
bot
removed
the
github_actions:pull-request
Member
Author
Indeed. I'm unfortunately out of bandwidth right now for tests (which could have captured this) -- maybe our test guru @AugustinMauroy can help us here 🙏 |
Member
Author
|
cc @nodejs/nodejs-website fast-tracking as a hot fix 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the compatibility engine to simply say it is compatible when on a loading state.